Skip to content

Fix docblock for Path::makeAbsolute #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/Path.php
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ public static function isRelative($path)
* // => C:/style.css
*
* Path::makeAbsolute("C:/style.css", "/webmozart/puli/css");
* // InvalidArgumentException
* // => C:/style.css
* ```
*
* If the base path is not an absolute path, an exception is thrown.
Expand All @@ -570,9 +570,7 @@ public static function isRelative($path)
*
* @return string An absolute path in canonical form.
*
* @throws InvalidArgumentException If the base path is not absolute or if
* the given path is an absolute path with
* a different root than the base path.
* @throws InvalidArgumentException If the base path is not absolute.
*
* @since 1.0 Added method.
* @since 2.0 Method now fails if $path or $basePath is not a string.
Expand Down