-
Notifications
You must be signed in to change notification settings - Fork 24
[Snyk] Upgrade react-native from 0.73.6 to 0.80.1 #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[Snyk] Upgrade react-native from 0.73.6 to 0.80.1 #121
Conversation
Snyk has created this PR to upgrade react-native from 0.73.6 to 0.80.1. See this package in yarn: react-native See this project in Snyk: https://app.snyk.io/org/shamoilattaar-wednesday/project/23dc2955-1a0d-48a4-af49-06d3e4b79f8f?utm_source=github&utm_medium=referral&page=upgrade-pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @shamoilattaar-wednesday, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've opened this pull request to perform a significant dependency upgrade for the project. The primary goal is to bring the react-native framework up to its latest version, which helps ensure the application benefits from the most recent features, performance improvements, and security patches. This is an automated update initiated by Snyk to keep our dependencies current and secure.
Highlights
- Dependency Upgrade: The core mobile development framework, react-native, has been updated to its latest stable version.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Important Review skippedIgnore keyword(s) in the title. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request proposes a direct dependency upgrade for react-native
from version 0.73.6
to 0.80.1
. While automated, this change is critically flawed for this project. The project uses the Expo framework, where the React Native version is strictly managed by the Expo SDK. Attempting to upgrade react-native
independently, especially with such a large version jump, will break the build and cause runtime failures. The correct procedure is to upgrade the Expo SDK, which handles the update of react-native
and its related dependencies. This PR should be closed, and the upgrade should be performed using Expo's official tools.
@@ -74,7 +74,7 @@ | |||
"react-dom": "18.2.0", | |||
"react-i18next": "^15.0.1", | |||
"react-intl": "2.8.0", | |||
"react-native": "0.73.6", | |||
"react-native": "0.80.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This direct upgrade of react-native
is incorrect for an Expo-based project. The React Native version is tightly coupled with the Expo SDK version to ensure compatibility across the ecosystem.
- Incorrect Upgrade Path: You should not upgrade the
react-native
package directly. The correct method is to upgrade the Expo SDK usingnpx expo upgrade
. This command updates allexpo-*
packages andreact-native
to a compatible set of versions. - Version Incompatibility: The project uses Expo SDK 50, which requires
react-native@~0.73.6
. The target version0.80.1
is not supported by any stable Expo SDK version and is a significant leap that would include numerous breaking changes.
This change will break the project. Please close this PR and follow the official Expo upgrade documentation.
Coverage report
Report generated by 🧪jest coverage report action from cd091d5 |
Snyk has created this PR to upgrade react-native from 0.73.6 to 0.80.1.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 608 versions ahead of your current version.
The recommended version was released a month ago.
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: