Skip to content

Set visibility: visible after animation finishes #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 13, 2025

Conversation

whitphx
Copy link
Owner

@whitphx whitphx commented Aug 12, 2025

Fixes #163

Copy link

changeset-bot bot commented Aug 12, 2025

🦋 Changeset detected

Latest commit: 5baed7b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slidev-addon-fancy-arrow Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@whitphx whitphx marked this pull request as draft August 12, 2025 18:09
@whitphx whitphx marked this pull request as ready for review August 13, 2025 01:32
@whitphx whitphx requested a review from Copilot August 13, 2025 01:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issue #163 by adding animation support for arrow content/text that appears after the arrow drawing animation completes. The change ensures that when arrows are animated, their content remains hidden during the arrow drawing phase and becomes visible only after the animation finishes.

  • Added content animation that synchronizes with arrow drawing animation
  • Exported animation duration constant for reuse across components
  • Updated slides documentation to demonstrate animated arrow functionality

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
components/FancyArrow.vue Added CSS animation and visibility logic to hide content during arrow animation and show it after completion
components/use-rough-arrow.ts Exported DEFAULT_ANIMATION_DURATION constant to make it available for other components
slides.md Added examples demonstrating animated arrows in the documentation
.changeset/cold-crews-fold.md Added changeset entry documenting the new animated overlay contents feature

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@whitphx whitphx merged commit 83df5ac into main Aug 13, 2025
7 checks passed
@whitphx whitphx deleted the fix/delay-overlay-content branch August 13, 2025 01:35
@github-actions github-actions bot mentioned this pull request Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlaid contents should be displayed after animation
1 participant