Skip to content

fix: improve ios log filtering #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: alpha
Choose a base branch
from
Open

fix: improve ios log filtering #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/logs/log-buffer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@

const noop = () => {};
const DEFAULT_SYNC_DELAY = 500;
const IOS_CONNECTION_REGEX = /^Connection (?:\d+|for <APSConnection)/;

export class LogBuffer implements StepLogRecorder {
private readonly _emitter: Emitter;
Expand Down Expand Up @@ -193,7 +194,17 @@
}

if (entry.level >= Level.ERROR) {
return !entry.subsystem.startsWith('com.apple.'); // && !entry.msg.includes('(CFNetwork)');
if (!entry.subsystem && !entry.category) {
if (IOS_CONNECTION_REGEX.test(entry.msg)) {

Check failure on line 198 in src/logs/log-buffer.ts

View workflow job for this annotation

GitHub Actions / Sanity 

Unexpected `if` as the only statement in a `if` block without `else`
return false;
}
}

if (entry.subsystem.startsWith('com.apple.')) {
return false;
}

return true;
}

return false;
Expand Down
Loading