-
Notifications
You must be signed in to change notification settings - Fork 148
[next]: Add data fetching and preview #2154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @ahuseyn!
I left some non-blocking feedback to consider.
return client.request(print(query), queryVariables); | ||
}); | ||
|
||
const results = await Promise.all(queryCalls); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using Promise.allSettled
instead of Promise.all
This would allow successful queries to return even if one fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Joe, my initial motivation to use Promise.all was this comment, but we should definitely reevaluate that approach in new Faust.
Description
This PR adds following:
and updates following:
Related Issue(s):