Skip to content

fix: navigate back to previous directory after SEA build #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 28, 2024
Merged

fix: navigate back to previous directory after SEA build #131

merged 2 commits into from
Dec 28, 2024

Conversation

JupiterPi
Copy link

fixes #130

robertsLando
robertsLando previously approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JupiterPi Thanks for your PR! LGTM

@robertsLando robertsLando enabled auto-merge (squash) December 27, 2024 08:28
@robertsLando
Copy link
Member

@JupiterPi Seems there are lint issues, could you fix them please? npm run fix

auto-merge was automatically disabled December 27, 2024 15:24

Head branch was pushed to by a user without write access

@robertsLando robertsLando enabled auto-merge (squash) December 28, 2024 13:42
@robertsLando robertsLando merged commit 1489e94 into yao-pkg:main Dec 28, 2024
48 checks passed
@JupiterPi
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertsLando robertsLando robertsLando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SEA builds change the working directory without navigating back, causing issues in build pipelines
2 participants
@JupiterPi @robertsLando