fix: prepare for edition 2024 #209
Conversation
Cargo.toml
Outdated
| [patch.crates-io] | ||
| half = { version = "2.4.1", git = "https://github.com/VoidStarKat/half-rs.git", tag = "v2.4.1" } | ||
|
|
There was a problem hiding this comment.
Downgrade indirect dependency half to 2.4.1 (2.5.0 requires MSRV 1.81.0)
Half upgraded to MSRV 1.81.0, that's why I had to downgrade it.
Would you like me to upgrade here too from 1.75.0?
Then I could remove this patch.
https://crates.io/crates/half/versions
Edition 2024 would require 1.85.0.
There was a problem hiding this comment.
Bumping to MRSV 1.81.0 allowed me to upgrade the last two outdated dependencies, is that ok?
There was a problem hiding this comment.
I see, thank you for clarifying. I have no objections to bumping the MSRV, but want to check with @matheus-consoli who introduced the MSRV checks before approving this.
There was a problem hiding this comment.
The alternative were to move benches into a separate create.
There you could manage the MSRV separately from release dependencies (half is an indirect dependency of criterion).
|
I saw that even more exotic runtimes like monoio are compatible, cool! Would it help your users to provide a more complete list of compatible runtimes like tokio-uring and test them internally? |
Fixes
cargo fix --edition(2021 -> 2024, but had to revert unstable expr_2021)Fixes #202