Global idle timeout #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the ping/pong mechanism used for liveness check. Previously we will always fire a ping every minute, even we know for sure the connection is alive as we are busy processing other messages like gossip updates. We now only fire a ping if we haven't received any messages from the peer after one minute.
Similar to how we delay sending pings on successful reads, we now delay sending pings if we know the connection is up and alive for writes.
Such that a busy reading won't make the writeHandler to time out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both read and write share the same idle timer, since we only care about whether the connection is idle or not but not the read or write process.