-
Notifications
You must be signed in to change notification settings - Fork 5
build: major dependencies update #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sourcery-ai summary |
@sourcery-ai review |
Reviewer's Guide by SourceryThis pull request migrates the project from Singularity to Apptainer, updates major dependencies including Snakemake and Python, and streamlines environment configurations by consolidating Conda environments and updating CI workflows to use the latest Ubuntu version and Miniforge. It also updates the default samples file path and removes obsolete files. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @uniqueg - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using
ubuntu-latest
instead ofubuntu-20.04
for the runner image to get the latest features and security updates. - The CI workflows now have duplicated blocks for setting up conda - consider creating a reusable workflow.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @uniqueg - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using
conda env export
to generate environment files to ensure reproducibility. - The CI workflows now use
ubuntu-latest
, ensure that this change does not introduce unexpected behavior due to differences in the environment.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@sourcery-ai guide |
Description
Fixes #180
Fixes #182
Fixes #183
Fixes #184
Fixes #185
Fixes #186
Fixes #187
Conventional Commits guidelines
https://www.conventionalcommits.org/en/v1.0.0/
Checklist:
(most are not applicable)
Summary by Sourcery
Migrate project from Singularity to Apptainer, update dependencies, and streamline environment configurations
New Features:
Enhancements:
Build:
CI:
Chores: