Skip to content

fix: Update language names to better represent embedded templates #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marcoroth
Copy link
Contributor

This pull request updates the language names for .html.erb and .yml.erb files.

The previous names HTML/ERB and YAML/ERB used a forward slash which semantically suggests "either/or" rather than the actual relationship where ERB is embedded within HTML or YAML.

Using HTML+ERB and YAML+ERB with a plus sign better conveys that these are composite languages.

@cla-bot cla-bot bot added the cla-signed label Aug 20, 2025
The previous names `HTML/ERB` and `YAML/ERB` used a forward slash
which semantically suggests "either/or" rather than the actual
relationship where ERB is embedded within HTML or YAML.

Using `HTML+ERB` and `YAML+ERB` with a plus sign better conveys
that these are composite languages
@vitallium
Copy link
Collaborator

vitallium commented Aug 21, 2025

I like that change! However, before releasing a new version with this update, we need to complete some prerequisites. Otherwise, some features like Tailwind autocomplete will be broken:

  • Update the Emmet extension
  • Add HTML+ERB and YAML+ERB to the Tailwind list of supported languages (here)
  • Wait for the new release of the Emmet extension
  • Wait for the new release of Zed
  • Merge this PR
  • Release the new version of the extension

@marcoroth
Copy link
Contributor Author

marcoroth commented Aug 21, 2025

Thanks for the feedback! I see the issue and wasn't aware what this is going to affect.

Kinda makes me wonder if the "Display Name" shouldn't be different from the "Language ID" itself.

Add HTML+ERB and YAML+ERB to the Tailwind list of supported languages (here)

We probably don't need Tailwind support in YAML+ERB files.

@vitallium
Copy link
Collaborator

Thanks for the feedback! I see the issue and wasn't aware what this is going to affect.

Kinda makes me wonder if the "Display Name" shouldn't be different from the "Language ID" itself.

Add HTML+ERB and YAML+ERB to the Tailwind list of supported languages (here)

We probably don't need Tailwind support in YAML+ERB files.

No worries, we still can land this PR. I will take care of updating Zed related parts.

@vitallium
Copy link
Collaborator

I created an issue to track all prerequisites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants