Deploy dependencies in AppImage #8562
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samuel <36420837+Samueru-sama@users.noreply.github.com>
sharun automatically sets `PATH` to include the `bin` dir. Zen binary is now in `bin/zen` instead of the top level of the AppDir Signed-off-by: Samuel <36420837+Samueru-sama@users.noreply.github.com>
Signed-off-by: Samuel <36420837+Samueru-sama@users.noreply.github.com>
dosubot
bot
added
the
size:M
Signed-off-by: Samuel <36420837+Samueru-sama@users.noreply.github.com>
mr-cheffy
approved these changes
May 23, 2025
|
Please run npm run pretty |
I'm not sure how to do that 😅 |
|
@Samueru-sama in the console run "npm run pretty" |
Signed-off-by: Samuel <36420837+Samueru-sama@users.noreply.github.com>
First time I use npm, hopefully it is all ok now. |
Signed-off-by: Samuel <36420837+Samueru-sama@users.noreply.github.com>
|
bumping thread to see if this can be merged. Is everything ok with this PR @mr-cheffy? I'd appreciate it very much if this gets to main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7967 and likely other similar issues.
So far Zen has just used the portable tarball build repacked as an AppImage, while this is usually good enough™ It means that the AppImage can't really work everywhere since the portable tar build depends on the host glibc.
These changes add the needed dependencies to guaranteed operation anywhere, such as musl distros and distros as old as ubuntu 14.04.
Considerations:
This change will break integration with appimaged and appimagelauncher since I switched the AppImage to dwarfs to reduce the final size (now 180 MiB). I could go back to squashfs but that makes the AppImage +250 MiB and I don't think it is worth it 👀
Note that this is unrelated to the infamous execv error people will still be able to launch it even on appimagelauncher, just that integration is broken due to it not being able to read dwarfs.
AM, dbin, Gearlever, soar, etc already support dwarfs so it is not an issue there.
Note I'm not able to figure out how the CI works, so I'm not sure if I made a mistake in the steps. 😅 I did testing here instead by using the tarball directly.