Skip to content

Fix: New Tab Menu Not Displayed During Fullscreen Video Playback #9838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

luisbettencourt
Copy link

Fixes #5229 by exiting fullscreen mode when opening the new tab menu.

@luisbettencourt luisbettencourt marked this pull request as ready for review August 10, 2025 18:36
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Bug labels Aug 10, 2025
Copy link
Contributor

@mr-cheffy mr-cheffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think exiting fullscreen is the best option to be honest. Maybe we should see why it isnt showing in the first place.

@luisbettencourt luisbettencourt marked this pull request as draft August 11, 2025 08:53
@luisbettencourt luisbettencourt marked this pull request as ready for review August 11, 2025 14:34
@luisbettencourt
Copy link
Author

I dont think exiting fullscreen is the best option to be honest. Maybe we should see why it isnt showing in the first place.

I tweaked the css that hides the sidebar when the browser is in fullscreen mode. Let me know if you think this is the correct approach.

Screencast.From.2025-08-11.15-39-43.webm

@luisbettencourt
Copy link
Author

luisbettencourt commented Aug 11, 2025

The URL Bar placement looks a bit weird when the Behavior setting is 'Normal' instead of 'Floating only when typing' or 'Always floating', as it slightly clips the top border. Should we always center it when in fullscreen mode or try to fix its position?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Tab Menu Not Displayed During Fullscreen Video Playback
2 participants