Support more Phillips Hue wall switch firmwares #4228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR differentiates between Philips wall switch devices based on firmware versions by updating class names and documentation to clarify which devices use old versus new firmware.
- Updated existing
PhilipsWallSwitchclass documentation to specify it's for old firmware devices - Renamed
PhilipsWallSwitchRDM004toPhilipsWallSwitchNewFirmwareand expanded its model support - Added support for both RDM001 and RDM004 models in the new firmware class
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4228 +/- ##
=======================================
Coverage 92.11% 92.11%
=======================================
Files 357 357
Lines 11878 11878
=======================================
Hits 10941 10941
Misses 937 937 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheJulianJES
approved these changes
Aug 24, 2025
TheJulianJES
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This pull request updates the
PhilipsWallSwitchdevice definitions to differentiate between devices using old and new firmware.PhilipsWallSwitchclass to specify that it represents devices using old firmware. (zhaquirks/philips/wall_switch.py, zhaquirks/philips/wall_switch.pyL91-R91)PhilipsWallSwitchRDM004class toPhilipsWallSwitchNewFirmwareand updated its docstring to reflect support for devices using new firmware. (zhaquirks/philips/wall_switch.py, zhaquirks/philips/wall_switch.pyL152-R161)MODELS_INFOin thePhilipsWallSwitchNewFirmwareclass to include both RDM001 and RDM004 models. (zhaquirks/philips/wall_switch.py, zhaquirks/philips/wall_switch.pyL152-R161)Additional information
Checklist
pre-commitchecks pass / the code has been formatted using Black