-
Notifications
You must be signed in to change notification settings - Fork 855
Add Candeo LC20 smart LED controllers, RD1/RD1P rotary dimmers #4234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…ry dimmer switches Adds support for the following Candeo devices: C-ZB-LC20-Dim / C-ZB-LC20-DIM C-ZB-LC20-CCT C-ZB-LC20-RGB C-ZB-LC20-RGBW C-ZB-LC20-RGBCCT C-ZB-RD1 C-ZB-RD1P-DIM C-ZB-RD1P-REM C-ZB-RD1P-DPM @TheJulianJES would you mind giving us some pointers should there be any need for unit tests for these?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4234 +/- ##
==========================================
+ Coverage 92.05% 92.15% +0.10%
==========================================
Files 350 360 +10
Lines 11602 11963 +361
==========================================
+ Hits 10680 11025 +345
- Misses 922 938 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fix pre-commit.ci failure
You can remove |
@puddly I thought direction was a required field, If I remove it then I get an error:
Apologies if I've misunderstood what you meant! |
Make sure you're using the latest version of zigpy and all of the other packages. |
Ah right, we're just on the latest HA release (2025.7.4), we'll switch to the beta channel and recheck. |
Removed direction= from all of the command definitions.
Removed unneeded import.
@puddly we've updated the code, please let us know if anything further is required. Thanks for your help! |
Use actual data value for device automation triggers rather than enum. Using an enum throws an "unsupported schema data type" error in HA itself when creating an automation.
Proposed change
Adds support for the following Candeo devices:
C-ZB-LC20-Dim / C-ZB-LC20-DIM
C-ZB-LC20-CCT
C-ZB-LC20-RGB
C-ZB-LC20-RGBW
C-ZB-LC20-RGBCCT
C-ZB-RD1
C-ZB-RD1P-DIM
C-ZB-RD1P-REM
C-ZB-RD1P-DPM
Additional information
@TheJulianJES would you mind giving us some pointers should there be any need for unit tests for these?
Checklist
pre-commit
checks pass / the code has been formatted using Black