Skip to content

Conversation

Shulyaka
Copy link
Contributor

Proposed change

ZHA now ignores all endpoints which are neither with ZLL nor ZHA profile.
This PR moves XBee replacement endpoints to ZHA profile.

Additional information

Device diagnostics

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works
  • Device diagnostics data has been attached

Copy link

codecov bot commented Aug 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.12%. Comparing base (746d5ba) to head (c54c193).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4287   +/-   ##
=======================================
  Coverage   92.12%   92.12%           
=======================================
  Files         358      358           
  Lines       11915    11915           
=======================================
  Hits        10977    10977           
  Misses        938      938           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheJulianJES TheJulianJES added the bugfix This PR fixes a bug label Aug 24, 2025
@TheJulianJES
Copy link
Collaborator

Ideally, we'd also have some diagnostics data in the ZHA repo for XBee devices. This would have been caught in advance then. Change done in ZHA PR:

Current ZHA code: https://github.com/zigpy/zha/blob/65644001a0ba19a04cfdd7c8cddc0a8e4710fb00/zha/zigbee/endpoint.py#L141-L146

We could also add an exception for XBee devices there? But for now, I think changing this via quirks is fine as well.

Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@TheJulianJES TheJulianJES merged commit 28d09e1 into zigpy:dev Aug 24, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants