Skip to content

fix: Fix ORGANICE_WEBDAV_URL not getting inserted correctly #952 #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

youguanxinqing
Copy link

Fix #952

There are three problems:
1、 No .env.sample in docker image of production.
Snipaste_2025-07-11_18-36-02

2、 Failed beacause $VALUE (enviroment value) contains '/'
when do sed -i "s/$KEY/$VALUE/g" "$DST"/**/*.js
Snipaste_2025-07-11_23-12-41

3、 $DST equals "serve" but serve -p 5000 -s build in entrypoint.sh.
set -x for entrypoint.sh and transient_env_vars.sh,we would get messages:

+ sed -i 's|ORGANICE_WEBDAV_URL|https://organice.example.org/dav|g' serve/public.2c69fddf.js serve/public.a9de6ea2.js
+ serve -p 5000 -s build

In reality, I think we should -s serve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ORGANICE_WEBDAV_URL not getting inserted correctly
1 participant