Skip to content

Conversation

RickBrannan
Copy link
Contributor

No description provided.

@RickBrannan RickBrannan requested a review from jacobwegner March 29, 2024 00:10
@jacobwegner
Copy link
Collaborator

@RickBrannan I updated the other datasets and just spot checked some changes against marble.bible:

{
    "key": "o390030220041",
    "changes": {
        "lexdomain": [
            "002002003003",
            "001001002003001 001001002003007 002003002024"
        ],
        "coredomain": [
            "017",
            "015 170 082"
        ],
        "sdbh": [
            "005188001001000",
            "005189001001000"
        ]
    }
}

Looks right at https://marble.bible/text?book=Malachi&chapter=3&verse=22&s=005188000000000&dictid=000000&db=Hebrew&textid=03900302200008

image

and in

https://marble.bible/dictionary?s=005188000000000&db=Hebrew

@jacobwegner jacobwegner force-pushed the rwb-domain-updates-2024-03-28 branch from 2b4d501 to 76adbd7 Compare March 29, 2024 20:02
@RickBrannan
Copy link
Contributor Author

@jacobwegner , I'm unclear on what you're trying to communicate to me. Are you indicating a problem, or a confirmation that all is well? As I look at the mapping data I generated and also at v0.9.1-en of the UBSDBH in the ubsicap/open-license repo, I see the following:

  • Macula o390030220041 and o390030220042 are mapped to MARBLE 03900302200008.
  • In the UBSDBH, 03900302200008 only occurs one time, in LexMeaning (or SDBH) 005189001001000.
  • In the LexMeaning, LexDomain of 001001002003001 (Classes), 001001002003007 (Officials), and 002003002024 (Serve) are specified.
  • In the LexMeaning, CoreDomain of 015 (Authority), 170 (Status), and 082 (Human) are specified.

These values appear to me to be what is reflected in WLC/Nodes for both o390030220041 and o390030220042, which is what I would expect.

@jacobwegner
Copy link
Collaborator

@RickBrannan: Sorry–I wasn't clear enough in the comment. I was saying things looked right to be in the "derived" datasets (TSV and Lowfat) after running your latest Nodes changes.

I wasn't asking for an explanation / audit of your work 😄.

I've got a couple of other things to wrap up before the release, but I'll go ahead and merge this over to main now.

@jacobwegner jacobwegner merged commit 5b48a1d into main Apr 1, 2024
@jacobwegner jacobwegner deleted the rwb-domain-updates-2024-03-28 branch April 1, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants