Install yarn.lock in target project #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a
yarn.lockfile a while back, but we weren’t installing it into the generated project.As a result, running
yarn installin the generated project can end up with newer dependencies than what we’ve tested with, which is not what we want.This PR copies the yarn.lock file into place in the generated project.
NOTE: This could cause a conflict if we were to run the generator in a project that is using a JS back-end, as that project might already have a
yarn.lockfile. This is already an issue forpackage.json, so I think we can safely choose to cross that bridge when we come to it.