Rename test scripts to match our conventions #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casto101
approved these changes
May 9, 2017
There was a problem hiding this comment.
It feels weird to me too that test forwards to test:watch. It doesn't feel like unnecessary duplication to have react-scripts called in both commands, because it might be a little clearer as to what each script is doing. But I'll approve this anyway, and leave changing it to your discretion--it's fine as it is, too.
lexun
approved these changes
May 9, 2017
It seemed weird to have the `test` script forward on to the `test:watch` script instead of the other way around, so instead I decided to duplicate the `react-scripts test` call. They’re side-by-side, and it’s not much duplication, so we can live with it.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of our JS packages have
testandtest:watchscripts, wheretestruns the tests once andtest:watchcontinuously runs them as files change. However, create-react-app defines only atesttarget that normally watches, but switches into “run once” mode if theCIenv var is set totrue. We originally wanted to keep our generator consistent with CRA, so we had atesttarget that does watch mode, and added a separatetest:oncetarget for doing a one-time run.This PR changes the scripts back to our normal convention of
testandtest:watch.It’s kinda weird to have the
testtask forward on to thetest:watchtask, but I didn’t want to repeat thereact-scriptscall in two places.