Use an absolute path as the eslint resolve root #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atom runs eslint from the directory containing the file being linted. Because we were using a relative path to the `client` directory as our resolve root, eslint was reporting errors and warnings because it wasn’t able to resolve some imports. A work-around would be to add an `.eslintignore` file to the root of the project, but a better solution is to use an absolute path to the `client` directory. To do that, we need to use `path.resolve`, so our config file must be JavaScript instead of JSON.
casto101
approved these changes
May 16, 2017
seanculver
approved these changes
May 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Atom runs eslint from the directory containing the file being linted.
Because we were using a relative path to the
clientdirectory as our resolve root, eslint was reporting errors and warnings because it wasn’t able to resolve some imports.A work-around would be to add an
.eslintignorefile to the root of the project, but a better solution is to use an absolute path to theclientdirectory.To do that, we need to use
path.resolve, so our config file must be JavaScript instead of JSON.Fixes #59