Update to latest zeal/react-scripts #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexun
approved these changes
Jun 16, 2017
create-react-app was designed to look at `NODE_PATH` when resolving imports; we were making a bunch of changes in `@zeal/react-scripts` to do the same job, but the upcoming version of `@zeal/react-scripts` will no longer do that. Instead, we add `NODE_PATH` to a `.env` file and that is used to resolve module imports.
The webpack options for resolver settings has changed with Webpack 2 (which is what the upcoming version of `@zeal/react-scripts` uses, so we need to change our configuration a bit. Ideally, we'd just point at `@zeal/react-scripts`' webpack configuration file, but that doesn't work (yet). See the comments in `app/templates/.eslintrc.js` for details.
Because of the way yarn resolves dependencies, we can sometimes end up in a situation where the eslint-loader depends on eslint@2.x instead of eslint@3.19.0, resulting in a number of lint warnings about unknown rules. The issue is that we only transitively depend on eslint via @zeal/react-scripts, but sass-lint depends on eslint@2.x. Since eslint-loader (and eslint-plugin-import) have peerDependencies that allow eslint@2.x, that's what they sometimes get. By depending directly on 3.19.0, those peerDependencies get resolved to that version because direct dependencies have priority over transitive dependencies.
Since we can't refer directly to our webpack config file, at least we can use the same paths as it configures instead of duplicating them.
The latest react-scripts will use this to open the browser to the correct location. By default, it's set to the same port as the front-end app, but can be changed when embedded in a back-end host application.
randycoulman
force-pushed
the
chores/update-to-cra-1.0-scripts
branch
from
2e8cdcb to
e935869
Compare
frank-west-iii
approved these changes
Jun 16, 2017
Also, minor fixes/cleanups.
randycoulman
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates ReactGen to zeal/react-scripts 2.0.0 (see CodingZeal/create-react-app#13).
Notes:
Adapts to the change in how we resolve modules. We now provide a
.envfile that setsNODE_PATHto./client.Supports the new
APP_PORTenvironment variable; this allows react-scripts to open the browser to the correct location when hosting in a back-end application. By default, we set it to the same port as the webpack dev server; client applications should edit this as appropriate to their context.Modifies the eslint configuration for Webpack 2. Because we need to use the webpack resolver, we have to update our configuration. See the comment in that file for all of the gory details of why I couldn't do it the way I wanted.
I had to add an explicit dependency on eslint 3.19.0. sass-lint pulls in a 2.x version of eslint, and the eslint loader would pull in that version instead of 3.19.0, resulting in numerous warnings about unknown rules. A better solution is Switch from sass-lint to stylelint #81 which will eliminate the old dependency.