Skip to content

fix the cluster not managed by FedLCM can be upgraded #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2023
Merged

fix the cluster not managed by FedLCM can be upgraded #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions server/application/service/participant_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,12 @@ func (app *ParticipantApp) getFATEClusterUpgradeableVersionList(ClusterUUID stri
return "", nil, err
}
participant := participantInstance.(*entity.ParticipantFATE)

//Check whether it is a cluster managed by fedlcm, a cluster not managed by fedlcm cannot be upgraded
if !participant.IsManaged {
return "", nil, errors.New("The cluster not managed by FedLCM cannot be upgraded.")
}

instance, err := app.ChartRepo.GetByUUID(participant.ChartUUID)
if err != nil {
ClusterChartVersion = utils.GetChartVersionFromDeploymentYAML(participant.DeploymentYAML)
Expand Down
10 changes: 10 additions & 0 deletions server/domain/service/participant_fate_upgrade_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ func (s *ParticipantFATEService) UpgradeExchange(req *ParticipantFATEExchangeUpg
}
exchange := participantInstance.(*entity.ParticipantFATE)

//Check whether it is a cluster managed by fedlcm, a cluster not managed by fedlcm cannot be upgraded
if !exchange.IsManaged {
return nil, nil, errors.New("The cluster not managed by FedLCM cannot be upgraded.")
}

if err := s.EndpointService.TestKubeFATE(exchange.EndpointUUID); err != nil {
return nil, nil, err
}
Expand Down Expand Up @@ -196,6 +201,11 @@ func (s *ParticipantFATEService) UpgradeCluster(req *ParticipantFATEClusterUpgra
}
cluster := participantInstance.(*entity.ParticipantFATE)

//Check whether it is a cluster managed by fedlcm, a cluster not managed by fedlcm cannot be upgraded
if !exchange.IsManaged {
return nil, nil, errors.New("The cluster not managed by FedLCM cannot be upgraded.")
}

if err := s.EndpointService.TestKubeFATE(cluster.EndpointUUID); err != nil {
return nil, nil, err
}
Expand Down