-
Notifications
You must be signed in to change notification settings - Fork 13
🔖 chore(*): DSFR-chart v2.0.4 #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix(storybook): use development files for storybook
fix(render): watch props
feat(chore): exports update
✅ Deploy Preview for dsfr-chart ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the DSFR-chart library to v2.0.4 by revising file paths for Storybook, adding watchers on component props to trigger chart re-renders, correcting shadow root handling for custom elements, and updating dependency configurations.
- Updated Vue components to re-render charts on prop changes
- Refactored custom element definitions to manage shadow roots internally
- Improved documentation and ESLint configuration
Reviewed Changes
Copilot reviewed 26 out of 27 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
src/components/LineChart.vue | Added a watcher on $props to reset and re-create the chart when props change |
src/components/GaugeChart.vue | Added a watcher on $props to re-create the gauge chart when props change |
src/components/BarLineChart.vue | Added a watcher on $props to reset data and re-create the chart as needed |
src/components/BarChart.vue | Added a watcher on $props to reset and re-create the chart when props change |
src/charts/*.js | Updated custom element definitions to supply shadowRoot: false in defineCustomElement and removed it from define |
eslint.config.js | Revised globals configuration for better ESLint parsing and consistency |
README.md & CONTRIBUTING.md | Updated documentation examples to reflect the new usage patterns |
.storybook/preview.js | Updated Storybook preview configuration to import the new chart runtime |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
src/charts/TableChart.js:8
- The configuration for shadowRoot is now passed into defineCustomElement while being removed from customElements.define. Verify that this change aligns with the intended behavior of rendering components without a Shadow DOM.
const TableChartElement = defineCustomElement(TableChart, { shadowRoot: false });
Closes #37
Closes #42
Closes #43
Closes #44
Closes #45
Resolves react-dsfr #391