[HS2][Screencap] Add new guideline types and resolution options in Tool Window #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SuitIThub
commented
May 2, 2025
SuitIThub
commented
- Implemented radiating lines, side V lines, and cross guidelines for enhanced screenshot guidance in Tool Window.
- Added buttons for selecting various default screenshot resolutions (HD, FHD, WQHD, 4K, 5K, 8K) in the Tool Window.
- 5K and 8K only visible with ExtremeResolutions Option active in settings
- Implemented radiating lines, side V lines, and cross guidelines for enhanced screenshot guidance. - Added buttons for selecting various screenshot resolutions (HD, FHD, WQHD, 4K, 5K, 8K) in the tool window. - Updated the guideline settings to include new options for user customization.
ManlyMarco
reviewed
May 3, 2025
There was a problem hiding this comment.
Changes look good but can you make this the same for the KK side as well? It should work as is so there's no reason not to add it to both. You can either just copy paste or extract a shared project if you want.
If one set of games starts getting modifications then it will be increasingly harder to share code later.
|
Yeah, I'll do that. I actually started work on that, but had some problems with the dependencies. And the fact that the KK Screencap is structured differently in the project. |
ManlyMarco
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.