Fix_DynamicBones - Fix another recursion error #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManlyMarco
approved these changes
Jan 12, 2025
ManlyMarco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recursion is hard.
After appending a particle, and doing the cursive call on its child, every normal particle would continue to add a leaf particle (obvious in hindsight).
The original game code did not have this issue, even though it also did not return after the recursion call, because it only adds a leaf when the transform associated with the particle has zero children. That, however, is also undesirable since it will not add a leaf particle if the bone chain ends prematurely.