Fix_DynamicBones - Fix append particles recursion error #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sorry that we have to update this code again in such a short time but this forloop in a whileloop in a recursive method got the better of me. |
ManlyMarco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return I implemented yesterday would obviously also stop the for loop form adding multiple children like the vanilla code can.
Inspired by the game code, which made adding the leaf require the particle to not have any children, I added a flag so that it can only add a leaf when particle did not add any of its children as particles. This is more similar to game code but also retains the ability to add a leaf particle when all children are in m_Exclusions.