Allow to pass trainable inducing inputs to AbstractVariationalGaussian #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaspinder
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
hatch run dev:formatbefore committing.Description
As things stand,
AbstractVariationalGaussiandefaults to staticinducing_inputsand making them trainable requires manual surgery. This PR enables passing trainable (i.e.Real) or fixed (i.e.Static)inducing_inputstoAbstractVariationalGaussian. When an array is passed asinducing_inputs, it is wrapped inRealby default, to mimic the default behaviour in other GP libraries.I am happy to write unit tests if required.
Issue Number: N/A