Skip to content

modern CMake #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2020
Merged

modern CMake #126

merged 1 commit into from
Feb 26, 2020

Conversation

Xeverous
Copy link
Contributor

  • bumped required CMake version
  • removed globbing
  • added targets with appropriate PUBLIC/PRIVATE properties
  • added an option to use pkg-config
  • added link-time optimization for release builds
  • added default build type
  • added some warnings and rewritten other compiler flags to use
    modern CMake functions
  • installed headers are in extra directory to avoid polluting global
    include directory
  • removed bii directory

- bumped required CMake version
- removed globbing
- added targets with appropriate PUBLIC/PRIVATE properties
- added an option to use pkg-config
- added link-time optimization for release builds
- added default build type
- added some warnings and rewritten other compiler flags to use
  modern CMake functions
- installed headers are in extra directory to avoid polluting global
  include directory
- removed bii directory
@Xeverous Xeverous mentioned this pull request Feb 25, 2020
@Xeverous
Copy link
Contributor Author

Apart from CMake version bump, the only breaking change is the new directory for includes. Includes like <file> are heavily discouraged and any library that installs itself in the root of include path risks overwriting other such libraries. The preferred way is <libname/file> (at least until C++20 modules).

@JosephP91 JosephP91 merged commit 5ac4d86 into JosephP91:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants