Improve perf of Document.save #2049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagerard
force-pushed
the
save_to_mongo_call_in_save
branch
from
6cd6f10 to
8fe0a16
Compare
bagerard
changed the title
bagerard
force-pushed
the
save_to_mongo_call_in_save
branch
from
8fe0a16 to
b92ede0
Compare
bagerard
force-pushed
the
save_to_mongo_call_in_save
branch
from
b92ede0 to
5fb0f46
Compare
bagerard
changed the title
|
@wojcikstefan @erdenezul Could you have a quick look at this when you have a chance? |
erdenezul
approved these changes
Jun 1, 2019
|
nice work man |
|
I'm a little late to the party, but this indeed looks very good. Thanks @bagerard! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document.save is currently making 2 calls to to_mongo (before and after validation), this is expensive when objects are very large. Since the first call was only used to identify if the document is created or updated, we could restrict the call with to_mongo(fields=['id'])