Oca top banner test #650
Closed
Oca top banner test #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbidoul
reviewed
May 10, 2025
There was a problem hiding this comment.
A couple of comments about stable URLs.
Can you also update the README.expected* files in https://github.com/OCA/maintainer-tools/tree/master/tests/data to fix the tests?
And rebase to get the latest CI updates and fixes.
| @@ -6,7 +6,12 @@ | |||
| {{ fragments[name] }} | |||
| {% endif %} | |||
| {%- endmacro -%} | |||
| ======= | |||
| .. image:: https://odoo-community.org/web/image/4610395-7254fada/OCA_banner_readme_1256x150px.png | |||
There was a problem hiding this comment.
Could we use a nice stable URL here and set up a redirect on the website? In case our website changes we would not want to break existing READMEs.
| @@ -6,7 +6,12 @@ | |||
| {{ fragments[name] }} | |||
| {% endif %} | |||
| {%- endmacro -%} | |||
| ======= | |||
| .. image:: https://odoo-community.org/web/image/4610395-7254fada/OCA_banner_readme_1256x150px.png | |||
| :target: https://odoo-community.org/get-involved?ref=k8vx13&utm_source=referral-readme&utm_medium=referral | |||
There was a problem hiding this comment.
What is "ref=k8vx13" ? Also here should we not use a stable URL in case the details of our website change in the future?
|
Ah, sorry, this is not the original PR. Let's close this one, I'll re-do my comments on the other one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for checking if creating a new PR can solve the issue of CI / Test with python 3.11 failing on my previous PR #642