[14.0] [FIX] mrp_bom_attribute_match: display proper BoM structure #1172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ivantodorovich, @ilyasProgrammer, |
francesco-ooops
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
Functional ok!
@ilyasProgrammer @ivantodorovich what do you think?
|
@ilyasProgrammer can you merge then? :) |
|
Thanks! /ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at afe58f6. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix the BoM structure was wrong, for example:
A BoM setup like this:
Would have always been showing this structure:
While instead should be showing the proper structure of the BoM:
Only when the right combination of product variant is chosen.