[16.0][MIG] mrp_bom_version: Migration to 16.0 #1368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[DEL mrp_bom_version, NEW mrp_bom_state]
[IMP] mrp_bom_version: fix flake8 [IMP]mrp_bom_version: fix travis
Updated to follow OCA conventions Explained in https://github.com/OCA/maintainer-tools/tree/master/template/module Update README.rst Update README.rst
…ion, and historical. Create _copy_bom, _update_bom_state_after_copy functions. [ADD] mrp_bom_new_version_when_component_change: Create a new version of BoM when are you going to change a component.
[IMP] mrp_bom_component_change: Include folder "tests", and programming improvements.
* When passing back to draft mantain active according to company definition * SQL sentence for state update in post-init-hook. * _bom_find with context state so that only those in state=active are taken into account * Tests * api.one deprecated [IMP] <mrp_bom_version> Little required changes [IMP] <mrp_bom_version> from api.one to api.multi [IMP] <mrp_bom_version> New tests added
* mrp_bom_reference_selection : Changed view id to enable use in other modules * mrp_bom_version : View copied to match the one in other modules
Currently translated at 100.0% (23 of 23 strings) Translation: manufacture-8.0/manufacture-8.0-mrp_bom_version Translate-URL: https://translation.odoo-community.org/projects/manufacture-8-0/manufacture-8-0-mrp_bom_version/gl/
Currently translated at 100.0% (23 of 23 strings) Translation: manufacture-8.0/manufacture-8.0-mrp_bom_version Translate-URL: https://translation.odoo-community.org/projects/manufacture-8-0/manufacture-8-0-mrp_bom_version/it/
kaycross
force-pushed
the
16.0-mig-mrp_bom_version
branch
2 times, most recently
from
ca5f3f1 to
0f09bc9
Compare
kaycross
force-pushed
the
16.0-mig-mrp_bom_version
branch
from
0f09bc9 to
a90ab95
Compare
matt454357
reviewed
Oct 21, 2024
mrp_bom_version/models/mrp_bom.py
Outdated
| version = fields.Integer( | ||
| states={"historical": [("readonly", True)]}, copy=False, default=1 | ||
| ) | ||
| parent_bom = fields.Many2one( |
There was a problem hiding this comment.
Suggestion: rename field parent_bom to previous_bom. The name parent_bom seems confusing, given the hierarchical nature of a bill of materials.
There was a problem hiding this comment.
Thanks for the suggestion, change done
There was a problem hiding this comment.
@matt454357 @kaycross : is it ok for you to aprove? I would like to merge it but I would need more aprovals.
Thank you!!!
anajuaristi
approved these changes
Oct 22, 2024
|
/ocabot migration mrp_bom_version |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 1368b61. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.