[17.0][MIG] mrp_component_operation #1455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ThiagoMForgeFlow dependency merged |
ThiagoMForgeFlow
force-pushed
the
17.0-mig-mrp_component_operation
branch
2 times, most recently
from
84c73fa to
c7b0637
Compare
ThiagoMForgeFlow
force-pushed
the
17.0-mig-mrp_component_operation
branch
2 times, most recently
from
6928524 to
c26d31d
Compare
DavidJForgeFlow
suggested changes
Jan 21, 2025
ThiagoMForgeFlow
force-pushed
the
17.0-mig-mrp_component_operation
branch
from
c26d31d to
58a614d
Compare
Currently translated at 97.8% (45 of 46 strings) Translation: manufacture-14.0/manufacture-14.0-mrp_component_operation Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_component_operation/it/
Manufacturing users should be allowed to operate components and therefore they need to be able to create and write the wizard model.
Currently translated at 100.0% (46 of 46 strings) Translation: manufacture-14.0/manufacture-14.0-mrp_component_operation Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_component_operation/it/
Currently translated at 100.0% (46 of 46 strings) Translation: manufacture-14.0/manufacture-14.0-mrp_component_operation Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_component_operation/it/
Currently translated at 100.0% (46 of 46 strings) Translation: manufacture-14.0/manufacture-14.0-mrp_component_operation Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_component_operation/it/
Currently translated at 100.0% (46 of 46 strings) Translation: manufacture-14.0/manufacture-14.0-mrp_component_operation Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_component_operation/it/
Currently translated at 100.0% (46 of 46 strings) Translation: manufacture-14.0/manufacture-14.0-mrp_component_operation Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_component_operation/it/
aditionally some adjustments have been done: - create_date is a magic field, no need to include it in the vals. - production_id is the inverse name of mo_id.scrap_ids.
Currently translated at 100.0% (49 of 49 strings) Translation: manufacture-14.0/manufacture-14.0-mrp_component_operation Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_component_operation/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-14.0/manufacture-14.0-mrp_component_operation Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_component_operation/
ThiagoMForgeFlow
force-pushed
the
17.0-mig-mrp_component_operation
branch
from
58a614d to
5e02764
Compare
DavidJForgeFlow
approved these changes
Jan 31, 2025
DavidJForgeFlow
suggested changes
Jan 31, 2025
mrp_component_operation/views/mrp_component_operation_views.xml
Outdated
Show resolved
Hide resolved
| def _run_outgoing_operations(self): | ||
| res = [] | ||
| if self.outgoing_operation == "scrap": | ||
| res = self._create_scrap() |
There was a problem hiding this comment.
scrap operation does not unreserve units in v17 maybe you should add part of the code below that unreserves units.
move = self.mo_id.move_raw_ids.move_line_ids.filtered(
lambda x: x.product_id == self.product_id
and (x.lot_id == self.lot_id or self.lot_id is False)
)
if move.quantity_product_uom == self.product_qty:
move.unlink()
else:
move.write({
"quantity_product_uom": (
move.quantity_product_uom - self.product_qty
),
}
)
move.move_id._recompute_state()
In v14 worked fine, so I supose there must be a change in how odoo creates scraps.
There was a problem hiding this comment.
A new functionality has been added to unreserve quantities in scraps. Thanks!
ThiagoMForgeFlow
force-pushed
the
17.0-mig-mrp_component_operation
branch
from
5e02764 to
daedbd4
Compare
ThiagoMForgeFlow
force-pushed
the
17.0-mig-mrp_component_operation
branch
from
daedbd4 to
32ec823
Compare
|
@DavidJForgeFlow could you update your review? |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
LoisRForgeFlow
approved these changes
Feb 24, 2025
|
/ocabot migration mrp_component_operation /ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
This PR has the |
|
Congratulations, your PR was merged at 01d50d4. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on OCA/stock-logistics-workflow#1816
@ForgeFlow