-
-
Notifications
You must be signed in to change notification settings - Fork 535
[15.0] [FIX] mrp_bom_attribute_match
: structure and cost report
#958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0] [FIX] mrp_bom_attribute_match
: structure and cost report
#958
Conversation
29939e1
to
d04c8d9
Compare
d04c8d9
to
c39e5bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not familiar with the module: code seems ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically seems good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@OCA/manufacturing-maintainers could this be merged? :) |
@pedrobaeza what do you think? |
Please squash a bit the commit history. |
Hello @pedrobaeza ! As it is right now, each commit is atomic, taking care of a specific concern. |
OK, as I haven't followed the thread, just do the administrative task given the reviews: /ocabot merge minor |
This PR looks fantastic, let's merge it! |
Thanks 🙏🏻 !! |
Congratulations, your PR was merged at b963089. Thanks a lot for contributing to OCA. ❤️ |
@ivantodorovich seems mrp_account_bom_attribute_match has corrupt readme, could you fix? |
Oops,. thanks for noticing @francesco-ooops ! |
This PR fixes two issues with this module:
mrp_account
's button "Compute Price from Bom"In both cases, when called on a bom that has a component template and no
product_id
set, a very similar traceback was raised:NOTE: It's easier to review commit by commit