Django3 compatibility #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that Django3 has an immutable QueryDict, so if we try to update it, it will fail. Making a copy and forcing it to be a dict will solved these problems (tested with djangosaml2idp as IDP and another djangosaml2idp as SP, both SP-initiated as well as IDP-initiated logins).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that Django3 has an immutable QueryDict,
so if we try to update it, it will fail. Making a
copy and forcing it to be a dict will solved these
problems (tested with djangosaml2idp as IDP and
another djangosaml2idp as SP, both SP-initiated
as well as IDP-initiated logins).