Skip to content

Conversation

emjay0921
Copy link
Contributor

@emjay0921 emjay0921 commented May 15, 2025

Why is this change needed?

To improve the icons for Menus for SP-MIS and SP-Farmer

How was the change implemented?

Changed the menus icons via XML Data, inheriting/overriding the Menus' Icons

New unit tests

None

Unit tests executed by the author

None

How to test manually

  • After Deployment on SP-MIS or SP-Farmer Instance.
  • Check if all the icons of the menus are now white lined.

Related links

#802

@emjay0921 emjay0921 linked an issue May 15, 2025 that may be closed by this pull request
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.14%. Comparing base (9783d41) to head (3f07323).

Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #809      +/-   ##
==========================================
- Coverage   76.16%   76.14%   -0.03%     
==========================================
  Files         766      766              
  Lines       20306    20306              
  Branches     2504     2504              
==========================================
- Hits        15467    15462       -5     
- Misses       4298     4301       +3     
- Partials      541      543       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emjay0921 emjay0921 marked this pull request as ready for review May 19, 2025 21:06
Copy link

sonarqubecloud bot commented Jun 4, 2025

@jeremi
Copy link
Member

jeremi commented Jun 17, 2025

@claude review this PR

Copy link

claude bot commented Jun 17, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

@jeremi
Copy link
Member

jeremi commented Jun 17, 2025

@claude review this PR

Copy link

claude bot commented Jun 17, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace icons
3 participants