-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(embedded-analytics): WIP Add embedded analytics UI #36699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
f9b3f59
to
b9cfdd1
Compare
Size Change: 0 B Total Size: 2.68 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated30 snapshot changes in total. 0 added, 30 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated23 snapshot changes in total. 0 added, 23 modified, 0 deleted:
Triggered by this commit. |
9552bf9
to
319eea2
Compare
📸 UI snapshots have been updated8 snapshot changes in total. 0 added, 8 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave it a skim through - generally looks good, don't think you want a thorough review here of the components as it's in WIP but let me know if that's not the case.
Should this live in the products folder? I wasn't sure if everything there is being loaded into the main bundle?
Yeah definitely not ready for an in-depth review yet, mostly tagged you as an FYI here's what I'm working on and here's my progress! |
Oh wasn't aware of this, I definitely don't want that |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated5 snapshot changes in total. 0 added, 5 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated5 snapshot changes in total. 0 added, 5 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Problem
Let's move this into the main repo
Changes
TODO
How did you test this code?
It'll have CI running visual regression tests