Skip to content

fix: fixed stylus vulnerability by using the npm provided - 0.0.1-security version #8592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025

Conversation

SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented Jul 23, 2025

📄 Summary

Fix: Add yarn resolution for stylus security vulnerability

Issue

The typescript-plugin-css-modules package depends on stylus@^0.59.0 (v5.0.1) or stylus@^0.62.0 (v5.1.0), which contains known security vulnerabilities.

Why upgrading the dependent package doesn't solve this

  • Even the latest typescript-plugin-css-modules@5.1.0 still requires stylus@^0.62.0
  • The original stylus package has been replaced in npm registry with stylus@0.0.1-security (a security stub)
  • Without explicit resolution, yarn shows warnings about version mismatches

Solution

Added yarn resolution to explicitly force stylus@0.0.1-security:

"resolutions": {
  "stylus": "0.0.1-security"
}

Debugging / Testing

  • yarn install completes without security warnings
  • yarn build runs fine
  • yarn why stylus shows forced resolution working correctly

✅ Changes

  • Feature: Brief description
  • Bug fix: Brief description

🏷️ Required: Add Relevant Labels

⚠️ Manually add appropriate labels in the PR sidebar
Please select one or more labels (as applicable):

ex:

  • frontend
  • backend
  • devops
  • bug
  • enhancement
  • ui
  • test

👥 Reviewers

Tag the relevant teams for review:

  • frontend / backend / devops

🧪 How to Test

  1. ...
  2. ...
  3. ...

🔍 Related Issues

Closes #


📸 Screenshots / Screen Recording (if applicable / mandatory for UI related changes)


📋 Checklist

  • Dev Review
  • Test cases added (Unit/ Integration / E2E)
  • Manually tested the changes

👀 Notes for Reviewers


Important

Update stylus to 0.0.1-security in package.json to fix a security vulnerability.

  • Dependencies:
    • Update stylus to version 0.0.1-security in package.json to address a security vulnerability.

This description was created by Ellipsis for c9c61de. You can customize this summary. It will automatically update as commits are pushed.

@SagarRajput-7 SagarRajput-7 requested review from YounixM and a team as code owners July 23, 2025 08:15
@github-actions github-actions bot added the bug Something isn't working label Jul 23, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to c9c61de in 57 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. frontend/package.json:258
  • Draft comment:
    The diff only updates the dependency 'stylus' to version 0.0.1-security for a vulnerability fix. However, the issue description mentions fixing an API call (ensuring URL params are correctly passed) and adding tests for it. This PR does not include those changes.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is pointing out a discrepancy between the PR description and the actual changes made in the PR. However, it is asking the author to update the PR description, which is against the rules. The comment is not providing a specific code suggestion or asking for a specific test to be written. Therefore, it should be removed.

Workflow ID: wflow_bmadGhhBw8RefZ3X

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@SagarRajput-7 SagarRajput-7 merged commit 08db2fe into main Jul 23, 2025
15 checks passed
@SagarRajput-7 SagarRajput-7 deleted the fix-stylus-issue branch July 23, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants