Skip to content

check if value is actually jinja before adding as template #5556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 2, 2022

Conversation

guzzijones
Copy link
Contributor

check if the value is actually jinja and not a string like {"someurl": "http://test?value={{test"}

@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines. Good size to review. label Jan 26, 2022
@cognifloyd cognifloyd enabled auto-merge January 26, 2022 20:01
@cognifloyd cognifloyd added this to the 3.7.0 milestone Jan 26, 2022
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include a Changelog for this fix.

Did you get an exception somewhere, how the error looked like?
A more specific example with steps to reproduce and log in the first message would help for the future history and others hitting the same issue.

@guzzijones
Copy link
Contributor Author

If your parameter value has a {{ or {% in it and it is not closed you will see the following exception in the st2workflowengine.log file: TemplateSyntaxError: expected token 'end of print statement', got 'string'

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for Changelog and additional context! 👍

@cognifloyd cognifloyd merged commit 1e65bf7 into StackStorm:master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M PR that changes 30-99 lines. Good size to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants