Skip to content

feat(starr): Update scene #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2025
Merged

Conversation

lucacome
Copy link
Contributor

@lucacome lucacome commented Aug 8, 2025

Pull Request

Purpose

I keep getting scene releases...

Approach

Open Questions and Pre-Merge TODOs

Requirements

Summary by Sourcery

Update the scene.json files for both Radarr and Sonarr to reflect the latest scene release formatting and criteria

Enhancements:

  • Revise scene.json custom format definitions for Radarr to incorporate updated scene release criteria
  • Revise scene.json custom format definitions for Sonarr to incorporate updated scene release criteria

Copy link
Contributor

sourcery-ai bot commented Aug 8, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR refines the ‘scene’ custom-format definitions for both Radarr and Sonarr by synchronizing and extending the JSON schema to better filter unwanted scene-release files.

File-Level Changes

Change Details Files
Bump and align schema metadata
  • Incremented spec_version to current standard
  • Unified top-level keys and descriptions
  • Applied consistent formatting and field order
docs/json/radarr/cf/scene.json
docs/json/sonarr/cf/scene.json
Enhance scene-release filtering rules
  • Added new regex patterns to catch edge-case scene tags
  • Updated include/exclude lists for better coverage
  • Removed obsolete entries no longer in use
docs/json/radarr/cf/scene.json
docs/json/sonarr/cf/scene.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added Area: Sonarr Sonarr Related Area: Radarr Radarr Related Area: Backend Backend Changes, not related to a specific section Area: Starr Custom Formats Issue is related to custom formats labels Aug 8, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lucacome - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lucacome lucacome changed the title Update scene.json feat(starr): Update scene Aug 8, 2025
Copy link
Contributor

github-actions bot commented Aug 8, 2025

Deploying with ⚡ Cloudflare Pages

Latest commit:efab0990fb7eac864f0e58728af3aabf27c12cdd
Status: ✅  Deploy successful!
Preview URL:https://496b975b.trash-guides-6xu.pages.dev
Branch Preview URL:https://pr-2447.trash-guides-6xu.pages.dev

@FonduemangVI FonduemangVI merged commit da3edbe into TRaSH-Guides:master Aug 9, 2025
10 of 11 checks passed
@TRaSH-
Copy link
Contributor

TRaSH- commented Aug 9, 2025

@lucacome, I think you forgot what I mentioned last time #2419 (comment).
Also, you didn't provide any examples, which is why we prefer to discuss/research this first in our Discord, so we can look into it and make changes to create a catch-all and not add like hundreds of scene RlsGRPs. In some cases, it's even possible to prevent scene releases with a simple setting in Prowlarr.

@lucacome lucacome deleted the scene branch August 9, 2025 18:02
@lucacome
Copy link
Contributor Author

lucacome commented Aug 9, 2025

@TRaSH- I didn't forget, this seemed like a pretty new and active group that popped up recently. I'll reach out in Discord next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section Area: Radarr Radarr Related Area: Sonarr Sonarr Related Area: Starr Custom Formats Issue is related to custom formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants