project_json_capabilites is very messy

[FAReTek1]

I have had issues when I have been trying to edit the project_json_capabilites.py file due to the nature that it has been coded. PyCharm really dislikes the code because it is full of stuff that the pep doesn't like:


37 warnings and 57 weak warnings!!!

overriding a builtin name!!

How is this readable?!?!?!?!?!?!? It's almost like a poem with its references that go to the left and right

Regardless of that, the methods are filled with 'potentially non-existent' attributes like self.sprite which are not defaulted to None , which makes code completion extremely unhelpful as these attributes are not listed, and it makes it very ugly as there are yellow underlines everywhere.

I have my own project json capabilites library called sbeditor and have a decent amount of experience with project json editing using scripts. the project_json_capabilites file is one I would really like to contribute to however these issues are making it really hard for me to edit. I may make a pr in response to this issue to address this

sorry if this seems like a rant

[FAReTek1]

i would also recommend making the project json capabilites a whole folder (like sa.site) since there is a fair amount of complexity to the project json system, although it's not entirely necessary

[FAReTek1]

i have now encountered severe fundamental issues in the system of sbeditor and will restart the project. i will probably integrate it directly into a branch of scratchattach in my own fork. if it becomes significantly more powerful than the current json capabilities, then i will open a pr

[TheCommCraft]

I would suggest you maybe take a look at custom json decoders

[FAReTek1]

wdym? can you send link

[TheCommCraft]

This might help: https://stackoverflow.com/questions/48991911/how-to-write-a-custom-json-decoder-for-a-complex-object
With that, you could have it be decoded directly into the needed classes

[FAReTek1]

ok. i think i might have an idea what to do

[FAReTek1]

i feel there may be issues with things like the lists which do not contain any identifying Information - the one that store numbers will be hard to differentiate from other lists. if youre unlucky, jt may be exactly equivalent to a scratch list. so afaik the to json and from json methods seem like an easier/potentailly cleaner way of programming it

[FAReTek1]

bad wording but hmm

[FAReTek1]

i am now working on a branch of scratchattach to do this

[FAReTek1]

see scratchattach/editor

[FAReTek1]

Parsing sb3 is now complete. Now we need exporting. Then editing, then come 'plugins'

[FAReTek1]

theyre not really plugins, just idk what to call them. ill talk about them more when i get to that point in development

[SpyC0der77]

So, in summary, you are making a python scratch project editor

[FAReTek1]

sbeditor v2