Skip to content

Conversation

FAReTek1
Copy link
Collaborator

This pull request fixes a typo in the Session,create_project() docstring and corrects the Project.download() function's filepath to have an extension of .json instead of .sb3, as it only downloads the project.json file, not the whole .sb3 file with all of the assets.

FAReTek1 and others added 5 commits October 29, 2024 22:08
(cherry picked from commit 791ee3e)
accidentally committed this to the wrong branch

Signed-off-by: FA ReTek <107722825+FAReTek1@users.noreply.github.com>
@TimMcCool
Copy link
Owner

Hi. Importing a sb3 file in Scratch also works when the sb3 file only contains the project JSON (Scratch will automatically load the assets from the API). Therefore, the .sb3 path is actually a feature and not a bug.

Everything else looks good tho.

@TimMcCool TimMcCool merged commit bf803e6 into TimMcCool:main Oct 31, 2024
@FAReTek1
Copy link
Collaborator Author

FAReTek1 commented Nov 1, 2024

Oh, i see.

@FAReTek1 FAReTek1 deleted the fixed-typos branch November 7, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants