-
-
Notifications
You must be signed in to change notification settings - Fork 141
Datetime planner: app #686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You don't need to care about introducing a breaking change in the app. I'm fine with raising the minimum backend version for this. This should make deserialization way easier. One thing I noticed: Make sure that the |
9aa9ac0
to
21e9a20
Compare
21e9a20
to
8a43939
Compare
Thanks for your feedback, @TomBursch . I didn't know about the interference with toJsonWithId, so I hope I did it right now. Another word of caution: I'm not a web developer and so I'm not always familiar with the Null Constraints of dart. Hence, please have a good look at every question or exclamation mark I use for e.g. a |
Hey @crosspolar, thanks for the patience. Could you rebase your changes? |
@TomBursch , hope that merge is okay. I've used GitHubs "Resolve conflict" button the first time... (I need to clean it anyway first) |
alright, you were faster cleaning 😄 |
@crosspolar yeah no worries 😄 Thanks again for this, looks really good! |
I had to replace the whole SelectDialog. My initial idea was having a Select Dialog for the next 7 days as we have it right now, but with the option to pick a date also. Maybe, however, it's better to have only the
DatePicker
to avoid extra clicks.TODO
day
in the API request, but think it potentially could reset the planned-date to the corresponding date of the same weekday within the next 7 days.