♻️ removing 'focused' prop from generic Input component #4557

MatissJanis · 2025-03-06T18:47:23Z

As far as I'm aware - this prop does not actually do anything. It might have done something earlier..

For example: the component is used when reconciling. Even with the removal of this focused prop - the auto-focus logic still works (via other logic we have in the codebase).

Removing this prop also makes it possible to move Input to the component library as it no longer relies on a higher-level context.

Looking for 2+ approvals prior to merging.

netlify · 2025-03-06T18:47:40Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`c2e2ade`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/67c9edbd44f15c0008988adb
😎 Deploy Preview	https://deploy-preview-4557.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2025-03-06T18:49:02Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
18	8.11 MB → 8.11 MB (-471 B)	-0.01%

Changeset

File	Δ	Size
`node_modules/clsx/dist/clsx.mjs`	🆕 +368 B	0 B → 368 B
`node_modules/clsx/dist/clsx.mjs?commonjs-proxy`	🆕 +64 B	0 B → 64 B
`node_modules/react-grid-layout/build/components/WidthProvider.js`	📈 +1 B (+0.02%)	5.22 kB → 5.22 kB
`node_modules/react-grid-layout/build/GridItem.js`	📈 +1 B (+0.00%)	21.49 kB → 21.49 kB
`node_modules/react-grid-layout/build/ReactGridLayout.js`	📈 +1 B (+0.00%)	24.96 kB → 24.96 kB
`src/components/select/DateSelect.tsx`	📉 -12 B (-0.13%)	9.28 kB → 9.26 kB
`src/components/util/AmountInput.tsx`	📉 -7 B (-0.17%)	3.96 kB → 3.96 kB
`src/components/modals/EditFieldModal.tsx`	📉 -15 B (-0.19%)	7.53 kB → 7.51 kB
`src/components/common/Modal.tsx`	📉 -24 B (-0.23%)	10 kB → 9.98 kB
`home/runner/work/actual/actual/packages/component-library/src/icons/v1/Subtract.tsx`	📉 -2 B (-0.48%)	415 B → 413 B
`src/components/util/PercentInput.tsx`	📉 -13 B (-0.58%)	2.17 kB → 2.16 kB
`src/components/common/InputWithContent.tsx`	📉 -17 B (-1.48%)	1.12 kB → 1.1 kB
`src/icons/v1/index.ts`	📉 -35 B (-2.15%)	1.59 kB → 1.56 kB
`src/components/accounts/Reconcile.tsx`	📉 -128 B (-2.34%)	5.34 kB → 5.21 kB
`src/components/common/Input.tsx`	📉 -117 B (-6.66%)	1.72 kB → 1.6 kB
`node_modules/clsx/dist/clsx.js`	🔥 -509 B (-100%)	509 B → 0 B
`node_modules/clsx/dist/clsx.js?commonjs-module`	🔥 -27 B (-100%)	27 B → 0 B

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/ReportRouter.js	1.59 MB → 1.59 MB (+67 B)	+0.00%

Smaller

Asset	File Size	% Changed
static/js/index.js	5.36 MB → 5.36 MB (-410 B)	-0.01%
static/js/wide.js	100.13 kB → 100 kB (-128 B)	-0.12%

Unchanged

Asset	File Size	% Changed
static/js/es.js	59.63 kB	0%
static/js/nl.js	103.3 kB	0%
static/js/fr.js	116.49 kB	0%
static/js/de.js	118.58 kB	0%
static/js/en-GB.js	96.66 kB	0%
static/js/en.js	106.5 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/useAccountPreviewTransactions.js	1.69 kB	0%
static/js/AppliedFilters.js	10.87 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/uk.js	111.06 kB	0%
static/js/pt-BR.js	110.52 kB	0%
static/js/narrow.js	88.44 kB	0%

github-actions · 2025-03-06T18:49:03Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	2.57 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	2.57 MB	0%

coderabbitai · 2025-03-06T18:57:24Z

Walkthrough

The pull request refactors multiple components by removing the management and propagation of the focused state. In several files—including Reconcile.tsx, Input.tsx, InputWithContent.tsx, Modal.tsx, EditFieldModal.tsx, DateSelect.tsx, AmountInput.tsx, and PercentInput.tsx—the focused prop and related state management logic have been eliminated. Additionally, some import paths have been updated, such as shifting the source of the theme and icon components from local paths to centralized modules. These changes simplify the components by discarding redundant focus handling while keeping the overall functionality intact.

Possibly related PRs

Fix mobile page header buttons #3491: Addresses removal of the focused prop from the Input component, reflecting similar modifications in the current PR.
Convert Mobile Transaction component to TransactionListItem + cleanup #3761: Involves stripping out the focused prop and related state management across several components, aligning closely with the changes introduced here.
♻️ (typescript) Refactor Accounts/Balances to tsx and Remove ts-strict-ignore from Accounts/Account #4047: Focuses on eliminating focus state management in the Reconcile.tsx component, directly correlating with the removal of the focused prop in multiple UI components.

Suggested labels

:sparkles: Merged

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 60a864a and c2e2ade.

⛔ Files ignored due to path filters (1)

upcoming-release-notes/4557.md is excluded by !**/*.md

📒 Files selected for processing (8)

packages/desktop-client/src/components/accounts/Reconcile.tsx (1 hunks)
packages/desktop-client/src/components/common/Input.tsx (2 hunks)
packages/desktop-client/src/components/common/InputWithContent.tsx (1 hunks)
packages/desktop-client/src/components/common/Modal.tsx (0 hunks)
packages/desktop-client/src/components/modals/EditFieldModal.tsx (1 hunks)
packages/desktop-client/src/components/select/DateSelect.tsx (1 hunks)
packages/desktop-client/src/components/util/AmountInput.tsx (1 hunks)
packages/desktop-client/src/components/util/PercentInput.tsx (0 hunks)

💤 Files with no reviewable changes (2)

packages/desktop-client/src/components/common/Modal.tsx
packages/desktop-client/src/components/util/PercentInput.tsx

🔇 Additional comments (12)

packages/desktop-client/src/components/common/InputWithContent.tsx (1)

16-16: LGTM: Addition of explicit focused prop type

Adding the optional focused prop type to InputWithContentProps aligns with the component's internal behavior, as it uses this prop for initialization but no longer forwards it to the Input component.

packages/desktop-client/src/components/accounts/Reconcile.tsx (1)

5-5: LGTM: Updated imports from centralized component library

The imports have been updated to source components from the centralized @actual-app/components library rather than relative paths, which is good for maintainability.

Also applies to: 9-9

packages/desktop-client/src/components/select/DateSelect.tsx (1)

16-17: LGTM: Updated imports for better maintainability

The imports have been updated to include type definitions and source the theme from a centralized component library, which improves maintainability and consistency.

packages/desktop-client/src/components/common/Input.tsx (2)

7-8: LGTM: Updated imports from centralized sources

Importing from centralized component library paths improves maintainability and consistency across the codebase.

42-42: LGTM: Simplified ref handling

The component now directly uses inputRef instead of a merged ref, which simplifies the code and aligns with the PR's goal of removing the focused prop and its related functionality.

packages/desktop-client/src/components/modals/EditFieldModal.tsx (4)

10-10: Import path updated for theme

The import path for theme has been updated from a local path to the centralized component library path. This change aligns with the PR objective of preparing for potential migration of components to the component library.

82-92: Removed focused prop from DateSelect

The focused prop has been removed from the DateSelect component while maintaining the auto-focus functionality. This simplifies the component's interface.

204-212: Retaining autoFocus while removing focused prop

The Input component still has autoFocus attribute but no longer uses the redundant focused prop. This maintains the desired behavior while simplifying the component's API.

220-226: Removed focused prop from amount Input

The focused prop has been removed from the Input component in the amount case, consistent with the changes in other cases.
packages/desktop-client/src/components/util/AmountInput.tsx (3)

14-15: Updated import paths for icons and theme

The import paths for SvgAdd, SvgSubtract, and theme have been updated to use the centralized component library paths. This enhances maintainability by using a consistent source for these dependencies.

118-153: Removed focused prop propagation to InputWithContent

The focused prop is no longer being passed to the InputWithContent component, while the AmountInput component still maintains its own focus management logic. This change aligns with the PR objective of removing the redundant 'focused' prop from the Input component hierarchy.

38-38:
❓ Verification inconclusive

Consider reviewing focus management strategy

While the focused prop has been removed from InputWithContent, the AmountInput component still maintains the focused prop in its interface and implementation. For consistency with the PR's objective, you might want to consider whether this component should also be refactored to use native autoFocus functionality instead.

Also applies to: 55-55, 73-77

🏁 Script executed:
#!/bin/bash
# Check if InputWithContent still accepts or uses a focused prop
grep -rn "focused" packages/desktop-client/src/components/common/InputWithContent.tsx
Length of output: 292
Action: Revisit Focus Management Across Input Components

The search shows that InputWithContent still uses the custom focused prop (e.g., lines 15–16, 27, 37, and 41). Meanwhile, AmountInput continues to define the same focused prop (line 38, plus related code at lines 55 and 73–77). For consistency—and assuming the PR's intent is to transition to native autoFocus—you should clarify the overall focus management strategy. Specifically:

Confirm if the goal is to replace custom focus handling with native autoFocus across both components.

If so, update both InputWithContent and AmountInput accordingly.

Otherwise, if the custom approach is maintained, remove or update comments that imply its removal in InputWithContent.

Please verify and align the focus management approach across the codebase.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

MatissJanis · 2025-03-06T19:01:14Z

@coderabbitai review

lelemm

Tried to break it, autofocus was working all the time

♻️ removing 'focused' prop from generic Input component

c2e2ade

actual-github-bot bot changed the title ~~♻️ removing 'focused' prop from generic Input component~~ [WIP] ♻️ removing 'focused' prop from generic Input component Mar 6, 2025

actual-github-bot bot added the 🚧 WIP label Mar 6, 2025

MatissJanis changed the title ~~[WIP] ♻️ removing 'focused' prop from generic Input component~~ ♻️ removing 'focused' prop from generic Input component Mar 6, 2025

actual-github-bot bot added 🔍 ready for review and removed 🚧 WIP labels Mar 6, 2025

joel-jeremy approved these changes Mar 6, 2025

View reviewed changes

actual-github-bot bot added ✅ approved and removed 🔍 ready for review labels Mar 6, 2025

lelemm approved these changes Mar 7, 2025

View reviewed changes

MatissJanis merged commit 4613899 into master Mar 7, 2025
21 checks passed

MatissJanis deleted the matiss/remove-focuesd-input branch March 7, 2025 09:14

actual-github-bot bot added ✨ merged and removed ✅ approved labels Mar 7, 2025

This was referenced Mar 7, 2025

♻️ (components) moving Input component to comp. library #4563

Merged

[Mobile] Fix autocomplete autofocus #4619

Closed

coderabbitai bot mentioned this pull request Apr 3, 2025

🐛 [Bug]: Focused console warning #4735

Merged

coderabbitai bot mentioned this pull request May 22, 2025

Update @actual-app/components/input to be based on react-aria-components Input component #4955

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

♻️ removing 'focused' prop from generic Input component #4557

♻️ removing 'focused' prop from generic Input component #4557

Uh oh!

MatissJanis commented Mar 6, 2025 •

edited

Loading

Uh oh!

netlify bot commented Mar 6, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 6, 2025

Uh oh!

github-actions bot commented Mar 6, 2025

Uh oh!

coderabbitai bot commented Mar 6, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

MatissJanis commented Mar 6, 2025

Uh oh!

lelemm left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

♻️ removing 'focused' prop from generic Input component #4557

♻️ removing 'focused' prop from generic Input component #4557

Uh oh!

Conversation

MatissJanis commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for actualbudget ready!

Uh oh!

github-actions bot commented Mar 6, 2025

Bundle Stats — desktop-client

Uh oh!

github-actions bot commented Mar 6, 2025

Bundle Stats — loot-core

Uh oh!

coderabbitai bot commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested labels

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

MatissJanis commented Mar 6, 2025

Uh oh!

lelemm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

MatissJanis commented Mar 6, 2025 •

edited

Loading

netlify bot commented Mar 6, 2025 •

edited

Loading

coderabbitai bot commented Mar 6, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)