Move sync-server to vitest #4840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jfdoming
commented
Apr 18, 2025
| const swap = (a, b) => { | ||
| const swap = normalizeTransactions[a]; | ||
| normalizeTransactions[a] = normalizeTransactions[b]; | ||
| normalizeTransactions[b] = swap; | ||
| }; | ||
| swap(1, 4); | ||
| swap(3, 6); | ||
| swap(0, 7); |
There was a problem hiding this comment.
Not sure how this test was passing before, as all these indices are out of range. Changed them to in-range
This comment was marked as resolved.
This comment was marked as resolved.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jfdoming
force-pushed
the
jfdoming/vitest
branch
from
63f4fb2 to
bb8d399
Compare
jfdoming
force-pushed
the
jfdoming/vitest
branch
from
df3de95 to
17efaec
Compare
This was referenced Apr 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it says on the tin. I know we got stuck in the previous attempt in #4212, but I'd really like to pick this up again and try to make incremental progress if that's at all possible. The biggest repository change since last time is the sync-server migration, so I'm hoping to knock it out first.