-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
⬆️ upgrade react dependencies to their newest minor version #5027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@coderabbitai are you able to collect the changes from the release notes of all of the packages I've bumped and post them here? |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain@matt-fidd I've collected the release notes for the packages that were bumped in this PR: Package Bumps Summary
Release Notesreact-router-dom (6.6.1 → 6.22.2)Notable changes across these versions include: New Features
Bug Fixes
Breaking Changes
@types/react-router-dom (5.3.3 → 6.22.0)This is a major version update that aligns the TypeScript definitions with the v6 API changes:
history package (removed)The
This update brings significant improvements to routing capabilities, better TypeScript support, and prepares for upcoming v7 features. 🏁 Script executed:
Length of output: 494 🏁 Script executed:
Length of output: 75 🏁 Script executed:
Length of output: 263 🏁 Script executed:
Length of output: 189 🏁 Script executed:
Length of output: 180 🏁 Script executed:
Length of output: 312 🏁 Script executed:
Length of output: 406 🏁 Script executed:
Length of output: 224 🏁 Script executed:
Length of output: 1081 🏁 Script executed:
Length of output: 261 🏁 Script executed:
Length of output: 181 🏁 Script executed:
Length of output: 1182 🏁 Script executed:
Length of output: 404 🏁 Script executed:
Length of output: 307 🏁 Script executed:
Length of output: 786 🏁 Script executed:
Length of output: 796 🌐 Web query:
💡 Result: Between versions 6.6.1 and 6.22.2 of Version 6.22.2 (February 28, 2024):
Version 6.22.1 (February 16, 2024):
Version 6.22.0 (February 1, 2024):
Version 6.21.3 (December 13, 2023):
Version 6.21.2 (December 6, 2023):
Version 6.21.1 (November 29, 2023):
Version 6.21.0 (November 22, 2023):
Version 6.20.1 (December 1, 2023):
Version 6.20.0 (November 22, 2023):
Version 6.19.0 (November 16, 2023):
Version 6.18.0 (October 16, 2023):
Version 6.17.0 (October 16, 2023):
Version 6.16.0 (September 19, 2023):
Version 6.15.0 (August 15, 2023):
Version 6.14.0 (July 18, 2023):
Version 6.13.0 (June 20, 2023):
Version 6.12.0 (June 6, 2023):
Version 6.7.0 (January 18, 2023):
Version 6.6.2 (January 9, 2023):
Version 6.6.1 (December 23, 2022):
For a comprehensive list of changes, you can refer to the React Router changelog. Citations:
🌐 Web query:
💡 Result: When upgrading from
These changes aim to simplify routing in React applications, improve performance, and provide a more intuitive developer experience. (reactrouter.com) Citations: 🌐 Web query:
💡 Result: Changes to the History Package in react-router-dom v6React Router v6 introduced major changes regarding routing history management compared to previous versions. Here are the most significant updates and their implications: 1. Removal of Direct history Object Usage
2. Introduction of useNavigate Hook
3. Replacing go, goBack, and goForward
4. Redirection API Changes
5. No More useHistory or history Prop
6. Handling Suspense and Navigation
Summary Table: v5 vs v6 Navigation and History
Migration Notes
React Router v6’s approach streamlines navigation and improves compatibility with React’s latest features, but applications that rely heavily on the history object or Citations:
@matt-fidd I've collected the release notes for the packages bumped in this PR: Package Version Changes
Release Notesreact-router-dom (6.6.1 → 6.22.2)New Features
Bug Fixes
Other Changes
@types/react-router-dom (5.3.3 → 6.22.0)This major version upgrade includes TypeScript definitions aligned with react-router-dom v6 API changes:
history (5.3.0) - RemovedThe
These changes represent a significant update to the routing system with improved React 18 compatibility and preparation for future React Router v7 features. |
WalkthroughThis pull request updates several dependencies in the Possibly related PRs
Suggested labels
Suggested reviewers
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
upcoming-release-notes/5027.md
is excluded by!**/*.md
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
📒 Files selected for processing (2)
packages/component-library/package.json
(1 hunks)packages/desktop-client/package.json
(1 hunks)
🔇 Additional comments (4)
packages/desktop-client/package.json (4)
66-66
:✅ Verification successful
Upgrade
react-router-dom
to 6.30.0
Ensure no remnants of deprecated APIs (e.g.,useHistory
) and that new features (like route transition hooks) are not inadvertently breaking existing routes.Run these searches:
🏁 Script executed:
#!/bin/bash # Find any old history hooks rg "useHistory" -n packages/desktop-client/src # Confirm correct use of <Routes> and `useNavigate` rg "useNavigate" -n packages/desktop-client/srcLength of output: 12300
No deprecated navigation APIs detected after upgrade to react-router-dom 6.30.0
I searched foruseHistory
(0 occurrences) and confirmed that all navigation now uses your customuseNavigate
hook wrapping React Router’suseNavigate
. There are no remnants of deprecated APIs, so this upgrade is safe to merge.
60-61
:❓ Verification inconclusive
Bump
react-grid-layout
to ^1.5.1 andreact-hotkeys-hook
to ^4.6.2
These UI utility libraries may introduce new options or deprecate old props. Check your layout callbacks and hotkey definitions for any signature changes.Search for common API usages:
🏁 Script executed:
#!/bin/bash # Verify grid layout usage rg "onLayoutChange" -n packages/desktop-client/src # Verify hotkeys usage rg "useHotkeys" -n packages/desktop-client/srcLength of output: 4012
Verify
onLayoutChange
anduseHotkeys
API signatures after bump
We’ve located your key usages—please confirm they still match the updated libraries’ callbacks:• onLayoutChange in
- packages/desktop-client/src/components/reports/Overview.tsx (lines 183, 528–529)
• useHotkeys across multiple components, e.g.:- SelectedTransactionsButton.tsx
- TransactionsTable.tsx
- FiltersMenu.jsx
- DynamicBudgetTable.tsx
- Titlebar.tsx
- accounts/Header.tsx
- HelpMenu.tsx
- common/Modal.tsx
Ensure none of these signatures changed in react-grid-layout@^1.5.1 or react-hotkeys-hook@^4.6.2—update your callbacks or options objects if needed.
69-69
:✅ Verification successful
Upgrade
react-stately
to ^3.37.0
Matches the ARIA/stately ecosystem updates. Validate that any updated state hooks (e.g.,useTreeState
,useMenuState
) still behave as expected.Check for state-hook usage:
🏁 Script executed:
#!/bin/bash # Search for stately hooks rg "useTreeState" -n packages/desktop-client/src || rg "useMenuState" -n packages/desktop-client/srcLength of output: 97
No usage of Tree/Menu state hooks found
A search inpackages/desktop-client/src
returned no occurrences ofuseTreeState
oruseMenuState
. Upgradingreact-stately
to^3.37.0
is safe, as none of the affected state hooks are used.
- Verified with:
rg "useTreeState" -n packages/desktop-client/src
rg "useMenuState" -n packages/desktop-client/src
54-55
:❓ Verification inconclusive
Upgrade
react-aria
to ^3.39.0 andreact-aria-components
to ^1.8.0
Syncing these packages ensures consistent ARIA support. Validate that any new hooks or props in v3.39.0/v1.8.0 are reflected correctly in your code.Use the following to search for imports and run tests:
🏁 Script executed:
#!/bin/bash # Check all imports of react-aria and react-aria-components rg "from ['\"]react-aria" -n packages/desktop-client/src rg "from ['\"]react-aria-components" -n packages/desktop-client/src # Run desktop-client test suite cd packages/desktop-client && npm testLength of output: 7550
Verify ARIA package upgrade and test suite configuration
All imports ofreact-aria
andreact-aria-components
inpackages/desktop-client/src
are already on versions^3.39.0
/^1.8.0
, but the Vitest suite failed to run (vitest: not found
). Before merging, please:
- Add or restore
vitest
inpackages/desktop-client/package.json
’s devDependencies (or adjust thetest
script to use your preferred runner).- Reinstall dependencies and confirm that
npm test
passes:cd packages/desktop-client npm install npm test- Validate any new hooks or props introduced in v3.39.0 / v1.8.0 are used correctly across:
packages/desktop-client/src/components/…
imports ofreact-aria
packages/desktop-client/src/components/…
imports ofreact-aria-components
No description provided.