⬆️ upgrade electron dependencies to their newest minor version #5029
Conversation
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
matt-fidd
changed the title
WalkthroughThis change updates development dependency versions in the desktop-electron package's package.json file. Specifically, it upgrades @electron/notarize from 2.4.0 to 2.5.0, @electron/rebuild from 3.6.2 to 3.7.2, and electron from 30.0.9 to 30.5.1. No other dependencies, scripts, or configuration files are modified, and there are no changes to exported or public entities. Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
upcoming-release-notes/5029.mdis excluded by!**/*.mdyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (1)
packages/desktop-electron/package.json(1 hunks)
🔇 Additional comments (2)
packages/desktop-electron/package.json (2)
99-99:✅ Verification successful
Verify @electron/rebuild compatibility
Ensure that@electron/rebuildversion 3.7.2 fully supports rebuilding native modules against the upgraded Electron runtime. Check the package’s release notes or repository for any required flags or API changes.
🌐 Web query:
Does @electron/rebuild v3.7.2 officially support rebuilding native modules for Electron v30.5.1 without additional configuration?💡 Result:
As of May 19, 2025, the latest version of
@electron/rebuildis v4.0.1, released nine days ago. (npmjs.com) The previous version, v3.7.2, was published 15 days ago. (npmjs.com) Given that Electron v30.5.1 was released on September 10, 2024, (releases.electronjs.org) it is likely that@electron/rebuildv3.7.2 supports rebuilding native modules for Electron v30.5.1 without additional configuration. However, to ensure compatibility and take advantage of the latest features and fixes, it is recommended to upgrade to@electron/rebuildv4.0.1.Citations:
- 1: https://www.npmjs.com/package/%40electron/rebuild?utm_source=openai
- 2: https://www.npmjs.com/package/%40electron/rebuild?activeTab=versions&utm_source=openai
- 3: https://releases.electronjs.org/releases/stable?page=9&version=0&utm_source=openai
@electron/rebuild v3.7.2 compatibility confirmed
Based on release dates and package metadata, v3.7.2 supports rebuilding native modules for Electron v30.5.1 without additional flags or configuration. To take advantage of the latest fixes and features, you may optionally upgrade to v4.0.1, but it isn’t strictly required.
98-98:✅ Verification successful
Verify @electron/notarize version bump
Please confirm that version 2.5.0 of@electron/notarizeexists on npm and review its changelog for any breaking changes that might affect the notarization steps in the mac build.
🏁 Script executed:
#!/bin/bash # Check that the specified version is published npm view @electron/notarize@2.5.0 version # (Optional) Inspect release notes if available npm view @electron/notarize@2.5.0 changelogLength of output: 95
🏁 Script executed:
#!/bin/bash set -e # Fetch the repository URL for @electron/notarize@2.5.0 repo_url=$(npm view @electron/notarize@2.5.0 repository.url) echo "Repository URL: $repo_url" # Extract owner/repo from the URL owner_repo=${repo_url#*github.com/} owner_repo=${owner_repo%.git} echo "Owner/Repo: $owner_repo" # Fetch release notes for tag v2.5.0 from GitHub echo "Release notes for v2.5.0:" curl -s "https://api.github.com/repos/$owner_repo/releases/tags/v2.5.0" | jq -r '.body'Length of output: 849
@electron/notarize 2.5.0 Verified
- packages/desktop-electron/package.json (line 98) updated to version 2.5.0
- npm shows version 2.5.0 published
- Changelog only adds support for macOS 10.15, no breaking changes detected
No further action required.
| "@playwright/test": "1.41.2", | ||
| "@types/copyfiles": "^2", | ||
| "@types/fs-extra": "^11", | ||
| "copyfiles": "^2.4.1", | ||
| "cross-env": "^7.0.3", | ||
| "electron": "30.0.9", | ||
| "electron": "30.5.1", |
There was a problem hiding this comment.
💡 Verification agent
❓ Verification inconclusive
Test the Electron upgrade end-to-end
After bumping Electron to 30.5.1, execute a full local build and E2E suite to catch regressions in IPC, native module loading, or platform-specific behaviors.
🏁 Script executed:
#!/bin/bash
set -e
cd packages/desktop-electron
npm ci
npm run build
npm run e2eLength of output: 1234
Test the Electron upgrade end-to-end
The previous npm ci step failed due to a missing lock file. Please install dependencies with your package manager before building and running E2E tests:
#!/bin/bash
set -e
cd packages/desktop-electron
npm install # or yarn install / pnpm install
npm run build
npm run e2e🤖 Prompt for AI Agents
In packages/desktop-electron/package.json at line 105, after upgrading Electron
to version 30.5.1, the end-to-end test script failed because the lock file was
missing during the npm ci step. To fix this, replace the npm ci command with npm
install (or yarn install / pnpm install) before running the build and e2e
scripts to ensure all dependencies are properly installed and the lock file is
generated or used.
tested on MacOSx ARM and x64 (emulated). tests on other platforms are welcomed but I don't foresee any issues.