fix(material/menu): incorrectly detaching lazy content when menu is transferred to a new trigger #31690
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ransferred to a new trigger The menu has some logic that detaches its lazy content when the animation is finished, however while the animation was running, the panel might've been picked up by another trigger. This ends up opening an empty menu panel to the new trigger. These changes resolve the issue by checking if another trigger picked up the panel before detaching the lazy content. Fixes angular#31687.
crisbeto
requested review from
mmalerba and
ok7sai
and removed request for
a team
andrewseguin
approved these changes
Aug 14, 2025
|
The changes were merged into the following branches: main, 20.1.x, 20.2.x |
crisbeto
added a commit
that referenced
this pull request
Aug 14, 2025
…ransferred to a new trigger (#31690) The menu has some logic that detaches its lazy content when the animation is finished, however while the animation was running, the panel might've been picked up by another trigger. This ends up opening an empty menu panel to the new trigger. These changes resolve the issue by checking if another trigger picked up the panel before detaching the lazy content. Fixes #31687. (cherry picked from commit b1514c4)
crisbeto
added a commit
that referenced
this pull request
Aug 14, 2025
…ransferred to a new trigger (#31690) The menu has some logic that detaches its lazy content when the animation is finished, however while the animation was running, the panel might've been picked up by another trigger. This ends up opening an empty menu panel to the new trigger. These changes resolve the issue by checking if another trigger picked up the panel before detaching the lazy content. Fixes #31687. (cherry picked from commit b1514c4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The menu has some logic that detaches its lazy content when the animation is finished, however while the animation was running, the panel might've been picked up by another trigger. This ends up opening an empty menu panel to the new trigger.
These changes resolve the issue by checking if another trigger picked up the panel before detaching the lazy content.
Fixes #31687.