[Bug] Cannot run program "zip" exception reported when Windows system compiles

[s7monk]

Search before asking

• I searched in the issues and found nothing similar.

Paimon version

master

Compute Engine

Flink

Minimal reproduce step

Because the paimon-e2e-tests module adds the zip configuration.After I update the code, compile with Windows system and report Cannot run program "zip" exception.

I put the zip.exe file in the bin directory of jdk, the problem is solved。

What doesn't meet your expectations?

no

Anything else?

No response

Are you willing to submit a PR?

• I'm willing to submit a PR!

[zhuangchong]

You may encounter a "Cannot run program 'zip'" exception. This is because Windows does not have the zip command installed by default, so Maven cannot find the executable.

To fix this, you need to have the zip command installed on your Windows system. You can download GNU zip for Windows from http://gnuwin32.sourceforge.net/packages/zip.htm, then add zip.exe to your system PATH environment variable.

[JingsongLi]

We can use jar instead of zip.

[q977734161]

I am willing to try this ticket, counld you assign it to me！

[tsreaper]

@q977734161 thanks for your interest in contributing! Before assigning you to this ticket, could you briefly explain how are you going to fix this issue? Which command are you going to use instead of zip -d?

[lianghuan-xatu]

@q977734161 thanks for your interest in contributing! Before assigning you to this ticket, could you briefly explain how are you going to fix this issue? Which command are you going to use instead of zip -d?

please assign it to me, and I will use the command "jar cvf test.jar dir/* --exclude dir/unwanted_directory/ --exclude dir/unwanted_file" instead of the command 'zip -d'. Thx!

[q977734161]

@tsreaper still use zip -d, but i am going to use maven-antrun-plugin instead of exec-maven-plugin ,At the same time, add the judgment script ,If the system is Windows , use certutil to download zip. exe, and then use the command zip - d; Otherwise, execute zip - d directly.

<if>
        <contains string="${os.name}" substring="Mac"/>
          <then>
                    <exec executable="certutil">
                            <arg line="-urlcache -split -f http://stahlworks.com/dev/zip.exe /tmp/paimon-e2e-tests-jars/zip.exe"></arg>
                    </exec>
                     <exec executable="/tmp/paimon-e2e-tests-jars/zip.exe">
                            <arg line=" -d /tmp/paimon-e2e-tests-jars/bundled-hadoop.jar org/apache/commons/cli/CommandLine.class"></arg>
                     </exec>
            </then>
            <else>
                     <exec executable="zip">
                          <arg line=" -d /tmp/paimon-e2e-tests-jars/bundled-hadoop.jar org/apache/commons/cli/CommandLine.class"></arg>
                      </exec>
            </else>
</if>

[tsreaper]

Hi @lianghuan-xatu @q977734161 , thanks for your solutions. In my opinion, using jar is a better solution than downloading zip.exe, because Paimon is a Java project and user must have jdk to build it. @lianghuan-xatu please submit a pull request as soon as possible.

[q977734161]

I think using jar is not very convenient either. We need to decompress the jar package , delete the class, and then package it. As jar do not support decompressing to the specified directory, Many commands are needed in the process
and different operating system commands are incompatible. It is necessary to write different scripts for each operating system.

[tsreaper]

Hi @q977734161 , thanks for your feedback.

You mentioned that for our current jar solution, it might be "necessary to write different scripts for each operating system". However your certutil solution is also exclusive to Windows as we don't have cerutil on Mac or Linux. I guess writing scripts for different operating system is not a strong downside.

Also, what I like the jar solution most is that it uses existing applications in the user's environment, rather than downloading a new one.

[q977734161]

Got it, I understand what your think now

[dbac]

Why does the bug close without fixing it?
@tsreaper @JingsongLi