Skip to content

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Jan 8, 2025

Description

log exceptions in CLI

Fixes #986

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

Copy link

codspeed-hq bot commented Jan 8, 2025

CodSpeed Performance Report

Merging #1000 will not alter performance

Comparing gmuloc:issue/986 (7b5df0a) with main (d21e443)

Summary

✅ 22 untouched benchmarks

@gmuloc gmuloc changed the title Feat(anta.cli): Better error message when invalid inventory or catalogs are parsed feat(anta.cli): Better error message when invalid inventory or catalogs are parsed Jan 8, 2025
Copy link

sonarqubecloud bot commented Jan 8, 2025

Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmuloc gmuloc merged commit 68c664d into aristanetworks:main Jan 8, 2025
25 checks passed
geetanjalimanegslab pushed a commit to geetanjalimanegslab/anta that referenced this pull request Jan 15, 2025
…gs are parsed (aristanetworks#1000)

* Feat(anta.cli): Better error message when invalid inventory or catalogs are parsed

* test: Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Silent exits when providing invalid inventory or catalog files
2 participants